Pr/remove rabitq reorder prefilter#689
Closed
xtangxtang wants to merge 13 commits intomicrosoft:cpp_mainfrom
Closed
Pr/remove rabitq reorder prefilter#689xtangxtang wants to merge 13 commits intomicrosoft:cpp_mainfrom
xtangxtang wants to merge 13 commits intomicrosoft:cpp_mainfrom
Conversation
- Add RaBitQ encoding/scoring utilities and builder tool - Optional RaBitQ reorder prefilter to prune reorder IO (INNER_PRODUCT) - Optional RaBitQ main-search approximate scoring, gated by env var - Support generating sidecar files during build_disk_index
Contributor
|
@xtangtang thanks for this amazing contribution. We are not actively maintaining the C++ version. The Rust version on main branch has a implementation of a variation of RabiTQ (under Spherical quantization). could you consider it? |
Contributor
|
Closing this PR for now. can reopen if needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR: Remove RaBitQ reorder-prefilter + README cleanup
What changed
This PR removes the previously added RaBitQ reorder prefilter feature end-to-end, while keeping RaBitQ main-search approximate scoring support.
DiskANN core (SSD search)
PQFlashIndex.<index>_rabitq_reorder.bin.DISKANN_USE_RABITQ_REORDER_PREFILTER/ related tuning env vars.Build / CLI integration
Documentation
Why
The reorder-prefilter mode is no longer desired; maintaining only the RaBitQ main-search mode simplifies the feature surface and avoids documenting/maintaining a removed behavior.
Notes